Fix access of lazy vals in traits compiled by 2.12 #3070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-2.12-lazy-vals
branch
from
62f2a44 to
a77c5a8
Compare
smarter
approved these changes
Sep 27, 2017
This was a case we did not consider before. Accessing a lazy val defined in a Scala 2.12 trait accessed an implementation class which did not exist. need special treatment to avoid this. P.S. It might be preferable to change lazy vals to not generate implementation class references in the first place. I don't know enough about its internals to be able to say whether that's feasible.
smarter
force-pushed
the
fix-2.12-lazy-vals
branch
from
a77c5a8 to
195840a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a case we did not consider before. Accessing a lazy val defined
in a Scala 2.12 trait accessed an implementation class which did not exist.
We need special treatment to avoid this.
P.S. It might be preferable to change lazy vals to not generate implementation class
references in the first place. I don't know enough about its internals to be able
to say whether that's feasible.